fix(Variable): Add params to the numPicker fn

twilio-labs / dev-phone

A developer tool for testing SMS and Voice applications

MIT License

75 stars 20 forks source link

fix(Variable): Add params to the numPicker fn #184

Closed hatealgebra closed 11 months ago

hatealgebra commented 11 months ago

Add params to the numPicker fn

Fixes the selectPn is undefined bug #182 .

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

[x ] I acknowledge that all my contributions will be made under the project's license.

ayyrickay commented 11 months ago

@hatealgebra I will give this a look in a few days, but can you add in a changeset? I think it might be a patch along the lines of "Improve resilience of the phone number picker component" or something

hatealgebra commented 11 months ago

Hi @ayyrickay, yup, I will look into it tomorrow.

hatealgebra commented 11 months ago

Hi @ayyrickay,

first time that I'm working with changeset. Hopefully I did it right. I've chosen patch, so it should be bumped by patch version up. Btw. Sorry, but I've been busy yesterday, so I'm looking into it today.