Add UI enhancements to the Verify Prefill demo

twilio-labs / function-templates

Twilio Function templates for different Voice, SMS, Video, Chat, Sync, etc use cases

MIT License

346 stars 323 forks source link

Add UI enhancements to the Verify Prefill demo #533

Closed cweems closed 4 months ago

cweems commented 4 months ago

Description

This pull request adds a new UI to the Verify Prefill demo. Additionally, it utilizes polling so that users don't wait 90+ seconds to see address results.

There are two issues I discovered while working on this PR:

node-fetch was set to version ^2.7.0, however that version will not work with require as seen in this function template. Is it working in production?
Tests are currently failing for this function template on main: Error verifying OTP: Error: Missing VERIFY_SERVICE_SID

@aricday and I will discuss further before merging.

Checklist

[ ] I ran npm test locally and it passed without errors.
[ ] I acknowledge that all my contributions will be made under the project's license.

cweems commented 4 months ago

@robinske Would you be able to work on reviewing this with me? This is a UI update for @aricday's recent verify pre-fill quick deploy.

robinske commented 4 months ago

Hey @cweems looks good - re: node-fetch v2.7.0 let me know if you have a different workaround but I did that intentionally for the tests (i'm sure there's a better way but that was the easiest fix I stumbled on) https://github.com/twilio-labs/function-templates/pull/523#discussion_r1635281108

robinske commented 4 months ago

The tests are passing on main for me locally so I'm not sure how to reproduce that one. I'll follow up/look into it more tomorrow!

welcome[bot] commented 4 months ago

Congratulations on your first contribution to the Twilio Function Templates! If you are on the look out for more ways to contribute to open-source, check out a list of some of our repositories at https://github.com/twilio/opensource. To stay up-to-date with Twilio open source related updates, sign up here: https://twil.io/oss-updates And if you love Twilio as much as we do, make sure to check out our Twilio Champions program!