search

twilio-labs / masked-communications-app

MIT License
16 stars 5 forks source link

getActiveProxyAddresses ignores closed conversations #8

Closed aymenn closed 2 years ago

aymenn commented 2 years ago

Added a check to conversation lookup logic to check the state. It will no longer use closed conversations since a conversation that is closed cannot be modified in any way, Also updated test case to include inactive and closed conversations in the mocked data

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

nataliehuynh commented 2 years ago

Test Suites: 11 passed, 11 total Tests: 34 passed, 34 total Snapshots: 0 total Time: 15.375 s

Tested creating conversation with participants, still need to test Participant list before closing