twilio-labs / paste

Paste is a design system for designing and building consistent experiences at Twilio.
https://paste.twilio.design
MIT License
443 stars 115 forks source link

Combobox Required has no bearing on Validity #4125

Open danielgarner365 opened 1 week ago

danielgarner365 commented 1 week ago

Description

When I have a ComboBox with required set inside a Form, I expect the following:

Link to Reproduction

https://codesandbox.io/p/sandbox/twilio-paste-combobox-required-debugging-ty4ftj

Steps to reproduce

  1. Go to Code Sandbox Twilio Paste Template with Form and Combobox
  2. Inside the form, click Submit.
  3. See the message on the Input component - "Please fill in this field" - thereby indicating that the required property is working.
  4. Enter a value in the Input component.
  5. Do not select an item in the Combobox component.
  6. Click submit again.
  7. Note that we did not get a message regarding there being no value set on the Combobox and if we look in the console, we can see that the form has indeed been submitted.

Paste Core Version

latest

Browser

Google Chrome 129.0.6668.101 (Official Build) (arm64)

Operating System

Additional Information

No response

dosubot[bot] commented 1 week ago

I found related discussions that might be helpful:

serifluous commented 6 days ago

Hey @danielgarner365 ! You can check out the 3rd link Dosubot posted above for our response to a similar question.

I'll close this issue in a bit unless you have more questions.