twilio-labs / serverless-toolkit

CLI tool to develop, debug and deploy Twilio Functions
https://www.twilio.com/docs/labs/serverless-toolkit
MIT License
109 stars 57 forks source link

`context.DOMAIN_NAME` is `localhost:3000` even when running through ngrok #474

Open coaxial opened 1 year ago

coaxial commented 1 year ago

I am not a paid ngrok.io user, and in my functions I have code that uses context.DOMAIN_NAME to pass options do Dial and record callbacks.

When running locally with npx twilio-run --live --inspect --env --ngrok, the value of context.DOMAIN_NAME is localhost:3000 instead of the actual ngrok hostname.

I have tried hardcoding DOMAIN_NAME=<ngrok domain name> after launching the server, but the env vars don't update then. And I can't set it up ahead of time because the ngrok domain name is random and not known in advance.

It would be nice to have context.DOMAIN_NAME return the ngrok domain name when run with the --ngrok option.

welcome[bot] commented 1 year ago

Thank you so much for opening your first issue in this project! We'll try to get back to it as quickly as possible. While you are waiting...here's a random picture of a corgi (powered by dog.ceo)

picture of dog