twilio-labs / serverless-toolkit

CLI tool to develop, debug and deploy Twilio Functions
https://www.twilio.com/docs/labs/serverless-toolkit
MIT License
109 stars 57 forks source link

[BUG] [@twilio-labs/serverless-runtime-types@4.0.0] Module '"twilio/lib/rest/Twilio"' has no exported member 'TwilioClientOptions' #521

Open ericbn opened 1 month ago

ericbn commented 1 month ago

Describe the bug Updating @twilio-labs/serverless-runtime-types from version 2.2.3 to 4.0.0 makes tsc fail with Module '"twilio/lib/rest/Twilio"' has no exported member 'TwilioClientOptions'. Indeed, I don't see it defined there.

To Reproduce Steps to reproduce the behavior:

  1. Current dependency in package.json is "@twilio-labs/serverless-runtime-types": "^2.2.3", (the latest <3 version)
  2. tsconfig.json contains "types": ["./node_modules/@twilio-labs/serverless-runtime-types/index.d.ts"],
  3. Running npx tsc works without errors
  4. Update to version 4.0.0 with npm install '@twilio-labs/serverless-runtime-types@4'
  5. Run npx tsc
  6. See error

Expected behavior tsc fails with

node_modules/@twilio-labs/serverless-runtime-types/types.d.ts:5:10 - error TS2305: Module '"twilio/lib/rest/Twilio"' has no exported member 'TwilioClientOptions'.

5 import { TwilioClientOptions } from 'twilio/lib/rest/Twilio';
           ~~~~~~~~~~~~~~~~~~~

node_modules/@twilio-labs/serverless-runtime-types/types.d.ts:415:10 - error TS2305: Module '"twilio/lib/rest/Twilio"' has no exported member 'TwilioClientOptions'.

415 export { TwilioClientOptions } from 'twilio/lib/rest/Twilio';
             ~~~~~~~~~~~~~~~~~~~

Found 2 errors in the same file, starting at: node_modules/@twilio-labs/serverless-runtime-types/types.d.ts:5

Screenshots

Desktop

Additional context I see TwilioClientOptions does not seem to exist in the twilio package starting with version 4, @twilio-labs/serverless-runtime-types@2.2.3 used twilio@3.84.1, and @twilio-labs/serverless-runtime-types@4.0.0 uses twilio@4.23.0. As far as I see, TwilioClientOptions was removed in commit b471067195b2e67d8073d70db6432cb14609fedb and never added back.

welcome[bot] commented 1 month ago

Thank you so much for opening your first issue in this project! We'll try to get back to it as quickly as possible. While you are waiting...here's a random picture of a corgi (powered by dog.ceo)

picture of dog