Disable focus workaround in Flex UI >= 2.7.1

twilio-professional-services / flex-project-template

A starting point for Twilio Flex projects, providing management strategies for various types of artifacts and distributed development

https://twilio-professional-services.github.io/flex-project-template/

Apache License 2.0

63 stars 67 forks source link

Disable focus workaround in Flex UI >= 2.7.1 #559

Closed dremin closed 3 months ago

dremin commented 3 months ago

Summary

The message focus bug was fixed in Flex UI 2.7.1 by FLXAGNTUI-93. Disable the workaround for 2.7.1 or later.

Checklist

[x] Tested changes end to end
[x] Requested one or more reviewers

github-actions[bot] commented 3 months ago

0 ESLint error(s) and 0 ESLint warning(s) found in pull request changed files. :white_check_mark: No issues found!

dremin commented 3 months ago

In theory the version check could fail with older versions and > 9 patches but I don't see that being an issue in practice. Semver lib could be considered as a pattern if we need to do version checks in the future?

But LGTM

Agreed, we should probably have a common template util for version checks that uses semver. I can get this added as a separate PR.