fixed error for "Can't use method return value in write context"

twilio / OpenVBX

OpenVBX is a web-based open source phone system for business.

http://openvbx.org

Other

702 stars 341 forks source link

fixed error for "Can't use method return value in write context" #254

Closed clarkewd closed 10 years ago

clarkewd commented 11 years ago

Without this change PHP throws an error:

Can't use method return value in write context

For notes on why the empty() function is not necessary see http://stackoverflow.com/questions/1075534/cant-use-method-return-value-in-write-context

Gipetto commented 10 years ago

This is code in the core CI libraries. I'm hesitant to merge this as its not OpenVBX code. I'm monitoring another PR that upgrades the CodeIgniter libraries to hopefully that can get merged and supersede the need to this request.

clarkewd commented 10 years ago

ah, i see - yes. I think that would be a good solution. thank you for looking at it.

Gipetto commented 10 years ago

Cool. Closing this. Fix will be included in #261