search

twilio / OpenVBX

OpenVBX is a web-based open source phone system for business.
http://openvbx.org
Other
699 stars 342 forks source link

Allow verified numbers to be used as outgoing caller id #259

Open chadsmith opened 10 years ago

Gipetto commented 10 years ago

Chad, If you can add a description on what to expect from this change and how to verify it I'll take a look. Its about time to clear this backlog and at least keep community contributions flowing.

chadsmith commented 10 years ago

Hi Shawn, It's good to hear someone is still working to keep OpenVBX alive. Let me know if you'd like any help.

This change adds the account's Outgoing Caller IDs to the caller ID dropdowns in OpenVBX. This will allow people to use the caller ID of their verified numbers in addition to their Twilio numbers. You can verify it by adding a Verified Caller ID to your account and dialing out with it from a flow. It also appears as an option in the iPhone and Android apps. If you don't have any verified numbers everything will continue to function as normal.

Gipetto commented 10 years ago

I don't like the CallerIds being merged with the IncomingPhoneNumbers in OpenVBX/libraries/User_Controller.php and in plugins/standard/applets/dial/ui.php. There's no way to tell the two types of numbers apart once they've been combined. Add to that the distinction should be apparent to the user when they're selecting a CallerId.

I think we should keep that data separate until the views so that we can introduce <optgroups/> in the CallerId menu to keep the CallerId and IncomingPhoneNumber lists separate, but in the same menu for ease of selection and not have to introduce any new logic in to the save and only need to mildly modify menu building logic.

ahfauth commented 7 years ago

Any update on that? It would be great if that worked!

Thank you!