twilio / OpenVBX

OpenVBX is a web-based open source phone system for business.
http://openvbx.org
Other
699 stars 342 forks source link

Sidebar Menu Navigation: Bug Fix #348

Closed jpwalters closed 8 years ago

jpwalters commented 8 years ago

Bug: The code only hightlights the menu as being selected if the pages are under "Messages, Setup and Admin" sections. If the pages are from a plugin they will never get marked as being selected because the $section and the $link never match.

Fix: The easiest fix was to add a forward slash into the if statement when comparing the current section to the current link. That was the only differece I could find and appeared to be the only reason why the code would never highlight the menu the user selected which clicking a plugin page.

sidebar-menu-navigation-selection

Gipetto commented 8 years ago

Looks good. I've merged this in to the develop branch and it'll go out in the next release.