Always prefer the sms body from the request over the cookie

twilio / OpenVBX

OpenVBX is a web-based open source phone system for business.

http://openvbx.org

Other

699 stars 342 forks source link

Always prefer the sms body from the request over the cookie #365

Open Natorator opened 8 years ago

Natorator commented 8 years ago

After six months or so of testing this on my own instance, I think I'm ready to have this fixed upstream. I haven't had any issues with preferring the request body over the cookie body.

Thoughts?

closes https://github.com/twilio/OpenVBX/issues/341 and perhaps https://github.com/twilio/OpenVBX/issues/266

gegere commented 8 years ago

It tested this for a length of time this is great! Looking to test this today, the code edits look great, hope this solves it.

gegere commented 8 years ago

Finally had the ability to test this on the problem OpenVBX account. I believe this update fixes the "deleted" message appearing within the SMS inbox. Nice job!

bluatwood commented 7 years ago

Hi, i've been having this same bug. how do i install the fix? just copy and replace the file on my OpenVBX installment? Sorry..a novice here.

Natorator commented 7 years ago

You could; it's fairly simple; have a look at the "files changed" tab, find the file in your deployment, and replace the red lines in that file with the green ones. The second red line is just a straight-up deletion. Be sure to test, and don't expect maintaining the change to be easy in the future unless you're really using git for version control.