search

twilio / audioswitch

An Android audio management library for real-time communication apps.
Apache License 2.0
163 stars 50 forks source link

Should `SystemClockWrapper` be internal? #67

Closed 4brunu closed 4 years ago

4brunu commented 4 years ago

Describe the bug When going thought the public API, I found that the class SystemClockWrapper is public, but from what I saw in the library, there is no reason for this class to be public, but maybe there is something that I didn't consider.

To Reproduce Steps to reproduce the behavior:

  1. Open class SystemClockWrapper
  2. The class should (maybe???) be internal, but it's public.

Expected behavior Since I see no reason for this class to be public, I was not expecting that it's in the public API.

Actual behavior The class SystemClockWrapper is public, but maybe it's needed for something?

Version

Alton09 commented 4 years ago

Thanks for pointing this out @4brunu ! That class is definitely supposed to have the internal access modifier. I went ahead and took care of this as part of #68.

4brunu commented 4 years ago

Thank you for the quick action 👍