twilio / authy-devise

Authy Devise plugin to add Two-Factor Authentication
MIT License
201 stars 84 forks source link

POST_disable_authy action does not clear the session["#{resource_name}_authy_token_checked"] variable #148

Closed RoseAndres closed 2 years ago

RoseAndres commented 3 years ago

I have parts of my layout views that are dependent on 2FA having been passed (which can be checked via the value of session["#{resource_name}_authy_token_checked"], which is set via record_authy_authentication in helpers.rb).

When I logged in as a User and verified with 2FA, then clicked a button that would POST to the disable_authy_path for my resource, it did not reset the session variable (session[:user_authy_token_checked] in my case). I checked the code for the POST_disable_authy action in devise_authy_controller.rb to verify and saw that there is no logic to clear this.

I will work on submitting a PR for a fix in the next day or so.

philnash commented 2 years ago

This library is no longer actively maintained. The Authy API has been replaced with the Twilio Verify API. Twilio will support the Authy API through November 1, 2022 for SMS/Voice. After this date, we’ll start to deprecate the service for SMS/Voice. Any requests sent to the API after May 1, 2023, will automatically receive an error. Push and TOTP will continue to be supported through July 2023.

Learn more about migrating from Authy to Verify.

Please visit the Twilio Docs for:

Please direct any questions to Twilio Support. Thank you!