Reformat legacy code in favour of guzzle

twilio / authy-php

A PHP client for Authy

245 stars 87 forks source link

Reformat legacy code in favour of guzzle #44

Closed dkusmierek closed 5 years ago

dkusmierek commented 6 years ago

I've found there are a lot of messy code as a residue after Resty library, which was used in your project. I've updated both AuthyResponse and AuthyUser classes in favor of guzzle HTTP library.

Changes:

added ResponseInterface type to AuthyResponse and AuthyUser constructor
removed an old $raw_response property (related to Resty)
updated all methods due to get data from an object which implements ResponseInterface

Tests:

no changes
all tests passed

luisuribe commented 5 years ago

Hi! Sorry for the late response. I fix the conflicts and move your PR to https://github.com/twilio/authy-php/pull/70 to be included in the next big change of the library.