search

twilio / authy-php

A PHP client for Authy
245 stars 87 forks source link

Update to Guzzle 7 #80

Closed aaronhuisinga closed 3 years ago

aaronhuisinga commented 3 years ago

This PR updates Guzzle to 7.x. In order to work with the 7.x Guzzle versions, we need to bump the minimum PHP requirement to 7.2, and also PHPUnit to 8.x.

All of this work is done in this PR, and the Docker scripts have been updated so that the test suite passes with these new dependency versions.

This should probably be tagged as a new major release due to the minimum PHP version increasing from 5.6.0 to 7.2.5.

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

luisuribe commented 3 years ago

Hi! Thanks for your work. I'll be reviewing this in the next few days and hopefully create a new major release

pelmered commented 3 years ago

This looks good to me. This is the only thing holding me back from upgrading to Guzzle 7 in our project.

StanBarrows commented 3 years ago

hey @luisuribe

Thanks for taking over the PR. Any chance to merge this? At the moment this is a blocker to update our application to Laravel 8.

Cheers Sebastian

StanBarrows commented 3 years ago

hey @luisuribe

Do you need some more changes, test or can I help you somehow that you can merge this PR?

Cheers Sebastian

luisuribe commented 3 years ago

Sorry, I was on PTO. I'll work on this ASAP.

r0bdiabl0 commented 3 years ago

Awesome, upgrading to Laravel 8 today and hit this issue so this will be nice. Thanks.

StanBarrows commented 3 years ago

Hey @luisuribe

How can I assist or help, so you can merge this PR?

Cheers

r0bdiabl0 commented 3 years ago

Sorry, I was on PTO. I'll work on this ASAP.

Any update?

MrMooky commented 3 years ago

Any update here? Is this project abandoned in favor of the newer Verify API? If so, this should be noted in the ReadMe.

MrMooky commented 3 years ago

This is really annoying, seriously. On your faq page it says: "Please use Verify for new use cases except those requiring Authy App push or TOTP (see FAQ).". Well, then keep the package up-to-date if you have no other solution yet. Simply merge this PR and most folks will be happy here.

schmoove commented 3 years ago

@luisuribe can we please have this PR merged? It's holding up a lot of projects. We require TOTP so can't use Verify in the meantime. Thank you.

guywarner commented 3 years ago

I'll bump this as well to get us able to fully upgrade.

markunsworth commented 3 years ago

Seems like there's a 4.0 RC2 that contains this but it's awaiting release. Is there anything holding it up?

MPJHorner commented 3 years ago

Anything I can do to stop this held up? Need this in our project RN.

luisuribe commented 3 years ago

Hi! I'm not longer part of Twilio, so cannot make a new release. Maybe someone else could help us // cc @robinske @philnash

erikvanderschaaf commented 2 years ago

@robinske @philnash please make a stable release for this

cforerofernandez commented 2 years ago

Seems like there's a 4.0 RC2 that contains this but it's awaiting release. Is there anything holding it up?

Hi, actually the 4.0.0-rc1 has this PR and is generated in packagist 4.0.0-rc1, so feel free to use it.