search

twilio / authy-php

A PHP client for Authy
245 stars 87 forks source link

Feature/upgrade to php 7 4 and take advantage of newer features #81

Closed ccmiller2018 closed 2 years ago

ccmiller2018 commented 3 years ago

This PR makes many contributions to the package that make use of the PHP7.4 additional features.

1) bumped PHP version to 7.4 in composer 2) added type hints for all versions 3) extracted some functionality to getters to allow clearer usage 4) fixes error in AuthyResponse typehint of array for the response to ResponseInterface 5) adds messages to all tests to allow easier identification of failure in test output 6) removes the Docker requirement 7) moves to make use of PHPUnit directly at PHPUnit 9.4 8) fixes deprecated functionality in PHPUnit tests 9) removes the un-needed TestHelper and TestCase files, replacing with PHPUnit versions 10) updates comments to describe usage of PHP 7.4 11) ensure all tests are still passing

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

ccmiller2018 commented 3 years ago

I have seen that the travis build fails above, however as this is an upgrade beyond travis's current setup, i feel this is something that could be looked at if the code is acceptable as the version jump will fail for older versions.

himanshu-mehta1 commented 3 years ago

@ccmiller2018 - Why are we removing docker?

robinske commented 2 years ago

This library is no longer actively maintained. The Authy API has been replaced with the Twilio Verify API. Twilio will support the Authy API through November 1, 2022 for SMS/Voice. After this date, we’ll start to deprecate the service for SMS/Voice. Any requests sent to the API after May 1, 2023, will automatically receive an error. Push and TOTP will continue to be supported through July 2023.

Learn more about migrating from Authy to Verify.

Please visit the Twilio Docs for:

Please direct any questions to Twilio Support. Thank you!