search

twilio / cocoapod-specs

https://www.twilio.com/
10 stars 15 forks source link

Compilation error in 2.0.0-beta9 #82

Open maxmeyers opened 7 years ago

maxmeyers commented 7 years ago

Similar to #75, but instead of a warning I'm setting an error. Strangely, this only happens if I try to use TVONotificationDelegate.

<module-includes>:1:1: error: umbrella header for module 'TwilioVoice' does not include header 'TwilioVoiceClient.h' [-Werror,-Wincomplete-umbrella]
#import "Headers/TwilioVoice.h"

I deleted TwilioVoiceClient.h from the Headers directory and that fixed the compilation error. Is it possible it was left in there by accident?

bobiechen-twilio commented 7 years ago

Hi @maxmeyers

Does this error message keep showing up after cleaning the build in Xcode? Indeed the TwilioVoiceClient.h is no longer needed but got still got included. We'll have it removed in the next release.

Thanks -bobie

maxmeyers commented 7 years ago

Yep, it's happening even after a "Clean build folder". For now we can commit the framework with the deleted header to our repo, but it would be nice to be able to use Cocoapods!

bobiechen-twilio commented 7 years ago

Ah, sorry for the inconvenience @maxmeyers. I've actually done a new build job locally to exclude TwilioVoiceClient.h from the framework and the built SDK worked well in the testbed. We'll get this fix in and push the next release ASAP.

Thanks again for reporting this.