twilio / rtc-diagnostics-react-app

Apache License 2.0
20 stars 10 forks source link

Ahoyapps 933 add passcode #31

Closed timmydoza closed 3 years ago

timmydoza commented 3 years ago

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

Pull Request Details

JIRA link(s):

Description

This PR adds extra random digits to the deployed serverless URL. It also adds some logic so that the app will expire one week after being deployed.

This is what is printed to the console after a deployment:

App deployed to: https://rtc-diagnostics-mk8gr9b4-5753-dev.twil.io
This URL is for demo purposes only. It will expire on Mon Nov 30 2020 12:52:32 GMT-0700

Image of UI of an expired app: image

Image of tooltip content: image

These warnings are displayed to the user after they try to run the network tests.

Edit - I updated the Icon to better match the designs: image

Burndown

Before review

Before merge

timmydoza commented 3 years ago

@charliesantos This is ready for another review. I have: