twilio / rtc-diagnostics-react-app

Apache License 2.0
20 stars 10 forks source link

Fix e2e tests #33

Closed timmydoza closed 3 years ago

timmydoza commented 3 years ago

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

Pull Request Details

JIRA link(s):

Description

This PR changes our e2e tests so that they don't rely on Functions and Assets being torn down immediately. Instead of asserting that all of the Functions will return a Not found error after the tests are finished, we instead assert that that the Service is correctly removed. We can assume that Twilio will eventually remove all of the Functions and Assets once the Service is removed.

Burndown

Before review

Before merge