[CLIENT-7685] Rename `pollIntervalMs` to `volumeEventIntervalMs`.

twilio / rtc-diagnostics

Other

46 stars 14 forks source link

[CLIENT-7685] Rename `pollIntervalMs` to `volumeEventIntervalMs`. #23

Closed mhuynh5757 closed 4 years ago

mhuynh5757 commented 4 years ago

Rename audio device test option pollIntervalMs to volumeEventIntervalMs for clarification.

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

[x] I acknowledge that all my contributions will be made under the project's license.

charliesantos commented 4 years ago

@mhuynh5757 code looks good. Do you know why build is failing?

mhuynh5757 commented 4 years ago

Seems like a flakey test regarding waitForPromise. I think I can solve this by using Sinon fake clocks. Perhaps a ticket for the next sprint?

charliesantos commented 4 years ago

That is fine for now.