search

twilio / terraform-provider-twilio

Terraform Twilio provider
MIT License
62 stars 13 forks source link

whitespace changes for identical json #120

Open liyifan5923013 opened 1 year ago

liyifan5923013 commented 1 year ago

Issue Summary

https://github.com/hashicorp/terraform-plugin-framework/issues/70

https://github.com/hashicorp/terraform-provider-aws/issues/25340#issuecomment-116160120

I’ve encountered an issue with terraform plan notify me when reading a json file that copy pasted from Twilio Console UI(The workflow configuration), that ~ resource "twilio_taskrouter_workspaces_workflows_v1" "voice_callback_workflow" { ~ configuration = jsonencode( # whitespace changes I think it might be fixable by changing the twilio-provider using DiffSuppressFunc, to treat jsons with whitespaces the same. Do you think it make sense for twlio-provider to add that? or any other suggestions you have for this situation?

Steps to Reproduce

  1. copy paste a standard json file from Twilio UI for a Twilio Workflow.
  2. using jsondecode and jsonencode to put it as configuration for workflow
  3. terraform plan
  4. you can see that there are # whitespace changes

Code Snippet

# paste code here

Exception/Log

# paste exception/log here

Technical details:

mattcole19 commented 1 year ago

This issue (DI-2437) has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog.

njsoria commented 2 months ago

This would be helpful as it's adding a ton of noise to my teams' plans