Docs never say that includes message with the given index for getMessagesAfter/Before - Githubissues

twilio / twilio-chat-demo-android

Chat API Demo Application for Android

MIT License

62 stars 51 forks source link

Docs never say that includes message with the given index for getMessagesAfter/Before #107

Closed rusmonster closed 5 years ago

rusmonster commented 5 years ago

From the docs for the Android SDK:

http://media.twiliocdn.com/sdk/android/chat/releases/4.2.3/docs/classcom_1_1twilio_1_1chat_1_1Messages.html#a4323575af08a2bb1cbf3195a0709d105

Never does it say that includes message with the given index (says before given index explicitly).

Alternatively:

https://www.twilio.com/docs/chat/result-paging#messages-android-ios (specifies including anchor message)
https://media.twiliocdn.com/sdk/ios/chat/releases/2.6.2/docs/Classes/TCHMessages.html#//api/name/getMessagesBefore:withCount:completion: (specifies including and prior)

Maybe Android docs could be updated? Same story with void com.twilio.chat.Messages.getMessagesAfter

Cheers!

Originally posted by @astamato in https://github.com/twilio/twilio-chat-demo-android/issues/92#issuecomment-539917570

rusmonster commented 5 years ago

fixed and will be released in the next SDK version

rusmonster commented 5 years ago

fixed in sdk 4.2.4