Open symunona opened 2 years ago
NOTE: I had to build to test it, I am not familiar with your pipeline, but Jeremy found that some of the generated files contain hard links to our repo.
Probably you'll need to cherry pick the first commit into a new PR and I assume your CI will take care of it?
Contributing to Twilio
Pull Request Details
JIRA link(s):
Description
A description of what this PR does. https://github.com/twilio/twilio-client.js/issues/188 Log lib scoping issue broke the build on AMD. Fixed by adding the lib to the repo with the fix from twilio-video, inspiration: https://github.com/twilio/twilio-video.js/pull/1352/files
Tests Looks like on the master branch there are a couple of broken files I did not touch, linter throws error on those, so testing failed but I am fairly confident the fix works, since I imported the built lib into our AMD system and it does not bail as before.
I did not add the unit tests, that looked a bit more complex.
Burndown
Before review
npm test
Before merge