twilio / twilio-client.js

Twilio’s Programmable Voice JavaScript SDK
https://www.twilio.com/docs/voice/client/javascript
Other
67 stars 32 forks source link

Client 7784 AMD support restore #300

Open symunona opened 2 years ago

symunona commented 2 years ago

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

Pull Request Details

JIRA link(s):

Description

A description of what this PR does. https://github.com/twilio/twilio-client.js/issues/188 Log lib scoping issue broke the build on AMD. Fixed by adding the lib to the repo with the fix from twilio-video, inspiration: https://github.com/twilio/twilio-video.js/pull/1352/files

Tests Looks like on the master branch there are a couple of broken files I did not touch, linter throws error on those, so testing failed but I am fairly confident the fix works, since I imported the built lib into our AMD system and it does not bail as before.

I did not add the unit tests, that looked a bit more complex.

Burndown

Before review

Before merge

symunona commented 2 years ago

NOTE: I had to build to test it, I am not familiar with your pipeline, but Jeremy found that some of the generated files contain hard links to our repo.

Probably you'll need to cherry pick the first commit into a new PR and I assume your CI will take care of it?