twilio / twilio-go

A Go package for communicating with the Twilio API.
MIT License
278 stars 40 forks source link

StreamServiceConversation always limited to 50 Conversations #109

Closed zs-codex closed 3 years ago

zs-codex commented 3 years ago

Issue Summary

We have more than 50+ Conversations but the StreamServiceConversation returned channel only receives up to the default 50 conversations before closing the channel. The expectation is that the channel returned by StreamServiceConversation will close only after all conversations have been retrieved.

Steps to Reproduce

  1. Create more than 50 service conversations for a service
  2. Attempt to Stream (or List) all of the conversations in the service
  3. Notice that the Stream ends at 50.

Code Snippet

    conversations, err := client.ConversationsV1.StreamServiceConversation(*service.Sid, &conversations.ListServiceConversationParams{})
    if err != nil {
        return err
    }

Technical details:

shwetha-manvinkurke commented 3 years ago

@zs-codex Thanks for reporting. Working on a fix here