twilio / twilio-go

A Go package for communicating with the Twilio API.
MIT License
278 stars 40 forks source link

fix:updating A2PProfileBundleSid parameter name #113

Closed MiguelDiaz1988 closed 2 years ago

MiguelDiaz1988 commented 2 years ago

Updating A2pProfileBundleSid to A2PProfileBundleSid parameter name to prevent error from API.

Fixes #112

Updating the parameter name send to Messaging API for the endpoint that creates Brand Registration in order to prevent it from returning an error of missing parameter (due to a typo).

Checklist

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

eshanholtz commented 2 years ago

Hi @MiguelDiaz1988

Thanks for the PR! Unfortunately, while this is the needed change, because this codebase is autogenerated, we'll actually need an associated fix in https://github.com/twilio/twilio-oai-generator and ensures the parameter name is cased properly each time this helper library is regenerated. Until a fix has been made there, I won't be able to merge this PR.

shwetha-manvinkurke commented 2 years ago

Closing this as a duplicate