search

twilio / twilio-go

A Go package for communicating with the Twilio API.
MIT License
278 stars 40 forks source link

Panic in BuildUrl - error is not handled #141

Closed kpritam closed 2 years ago

kpritam commented 2 years ago

We are seeing panics in our application.

While investigating, I figured out that BuildUrl function is ignoring error which is causing panic later in the flow.

This happens when you have wrong ServiceSid configured.

https://github.com/twilio/twilio-go/blob/main/client/request_handler.go#L32

JenniferMah commented 2 years ago

Hi @kpritam! Thanks for submitting a PR. Your PR is currently in our team's review backlog.