search

twilio / twilio-go

A Go package for communicating with the Twilio API.
MIT License
271 stars 40 forks source link

ssml tags are capitalized causing errors on twillio ml apps #207

Open comsma opened 11 months ago

comsma commented 11 months ago

Issue Summary

The twiml.VoiceProsody struct does not generate the right xml tag for prosody. ssml docs

Steps to Reproduce

  1. create a new struct for twiml.VoiceProsody
  2. observe that the tag is and not as per twillio documentation

Technical details:

AsabuHere commented 11 months ago

Hi @comsma, Thank you for the heads up! This issue has been added to our internal backlog to be prioritised. Pull requests and +1s on the issue summary will help it move up the backlog.

Thanks, Athira

abhishek-eltropy commented 9 months ago

Facing Warning 12200 Message: XML Validation warning

For SSML Tags e.g. "Break" should be "break" "S" should be "s"

Do we have ETA for the fixes? @AsabuHere

abhishek-eltropy commented 9 months ago

@twilio Should we use twilio-go sdk for production ? Or this library is still in beta ?

AsabuHere commented 9 months ago

We are working on this issue in the current sprint https://issues.corp.twilio.com/browse/DII-1185. Since these files are auto generated the above PR would not work. This need another PR to yoyodyne repo which generates these files. Otherwise these changes will be overwritten in the next release. The yoyodyne changes needs a detailed analysis and more work which may take some more time. We will keep this thread posted about the progress

AsabuHere commented 9 months ago

Hi @comsma, Can you please provide detailed steps on how to reproduce this issue? Please share a sample code snippet where this is used and what usage caused this exact error

Thanks, Athira

AsabuHere commented 8 months ago

Hi @comsma Any updates on this issue?

PhilThurston commented 5 months ago

@AsabuHere Detailed steps to reproduce were provided several days before (Oct 11, 2023) your last response to this issue in #221 where you asked for steps as well. It seems strange that you would follow-up to ask for them again. You said back on Oct 11, 2023 that it would slated for that current sprint. The relevant code on how to reproduce this was provided. Are there any further updates on when this will be resolved. From my understanding that sprint you had mentioned has come and gone.

It may be prudent to merge in the various pull requests that fix this issue until the twilio team can get around to resolving this long-standing issue.

comsma commented 5 months ago

@AsabuHere is there a new release that fixes the VoiceProsody tag?there was no communication in this issue