twilio / twilio-java

A Java library for communicating with the Twilio REST API and generating TwiML.
MIT License
484 stars 425 forks source link

fix: support different schema of meta properties #680

Closed shrutiburman closed 2 years ago

shrutiburman commented 2 years ago

Fixes DII-368

The response meta properties can have two structures, one where the meta tag is present and under those all properties are listed, another where the meta tag isn't there but the properties are present. This PR enables support for different variations of meta properties schema.

Checklist

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.5% 87.5% Coverage
0.0% 0.0% Duplication

childish-sambino commented 2 years ago

I'm not understanding why this change is needed in the existing code base. This isn't currently causing any problems. Is this a change that should be in oai-generator instead?

shrutiburman commented 2 years ago

This ticket was going to populate meta properties in case the properties are not nested under the tag "meta". Turns out, the current implementation handles this case with "uri" tag, which if present, the meta properties will be built from root nodes. So we are good here, without any modifications.