twilio / twilio-java

A Java library for communicating with the Twilio REST API and generating TwiML.
MIT License
484 stars 425 forks source link

fix: update examples as per specs #686

Closed shrutiburman closed 2 years ago

shrutiburman commented 2 years ago

Fixes DII-409

This PR: Updates the examples as per the generated specs files.

Checklist

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

childish-sambino commented 2 years ago

Not sure I understand this change. I didn't think there would be changes to the interface. Also, should this target the RC branch?

shrutiburman commented 2 years ago

Not sure I understand this change. I didn't think there would be changes to the interface. Also, should this target the RC branch?

The generated code doesn't have some fields that were there earlier, which was causing tests to fail. This is where we create the params list which is used in mustache file. Let me know if it looks sketchy ..

Also, it should go in the RC branch, my bad.