twilio / twilio-java

A Java library for communicating with the Twilio REST API and generating TwiML.
MIT License
482 stars 421 forks source link

chore: protected NetworkHttpClient field #735

Closed bcanseco closed 1 year ago

bcanseco commented 1 year ago

Fixes

This is a similar PR to #631.

This PR changes the access modifier for the NetworkHttpClient's client field from private to protected. Allows for extending classes to use this overridden field (e.g. if you'd want your own custom NetworkHttpClient to have a request method that sends as JSON instead of URL-encoded, but want everything else to be the same).

Verified that make test passes but haven't added any additional tests since it's just a simple access change / would just be testing a core Java feature. Lmk if we do want a test for this and I'd be happy to write something up.

Checklist

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

Hunga1 commented 1 year ago

Just need to update the branch with the base.