twilio / twilio-java

A Java library for communicating with the Twilio REST API and generating TwiML.
MIT License
484 stars 425 forks source link

fix: added new httpclient for noauth and bearertoken requests #808

Closed sbansla closed 1 month ago

sbansla commented 1 month ago

Fixes

With OAuth support HttpClient class method argument type got changed due to which it was breaking customer environment.

Before: twilio-java/src/main/java/com/twilio/http/HttpClient.java at de885af34a8a9e71c62b488b7119bccde5abc4de · twilio/twilio-java

After: twilio-java/src/main/java/com/twilio/http/HttpClient.java at ab74cef9752400749fe23b9d7345d8bea27864c9 · twilio/twilio-java

Revert the interface changes.

Create separate clients for BearerToken and NoAuth Requests

Checklist

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

sonarcloud[bot] commented 1 month ago

Quality Gate Failed Quality Gate failed

Failed conditions
55.0% Coverage on New Code (required ≥ 80%)
49.7% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint