search

twilio / twilio-node

Node.js helper library
MIT License
1.37k stars 495 forks source link

Regression: some call filtering params got removed in v5 #1013

Closed dmitriy-kudelko closed 3 months ago

dmitriy-kudelko commented 3 months ago

Issue Summary

Hello,

The rest/api/v2010/account/call (client.calls.list) API doesn't support startTimeBefore/startTimeAfter filtering params any more. AFAIU, there's no alternative way to achieve the same with just the startTime property since the SDK doesn't give a way to form REST API query params directly e.g. to append StartTime>=YYYY-MM-DD, or does it?

There's isn't a single word in release notes about this change, which only says this:

We ensured that you can upgrade to Node helper Library 5.0.0 version without any breaking changes of existing apis

So, a traditional rhetorical question that I have after experiencing a few such changes by Twilio is why such breaking changes are not properly documented and/or explained in release notes/migration guides?

And second... how do we filter calls now? Previously we relied on startTimeAfter which wasn't deprecated or anything BTW, but just got removed leaving us with no option to migrate to v5.

Technical details:

sbansla commented 3 months ago

@dmitriy-kudelko Issue is fixed in twilio-node version 5.0.1 Can you upgrade to this version.

dmitriy-kudelko commented 3 months ago

Hi, @sbansla

I can see them restored in 5.0.1. Thank you!