search

twilio / twilio-node

Node.js helper library
MIT License
1.37k stars 495 forks source link

Node.js v20 support #980

Closed electrovir closed 5 months ago

electrovir commented 7 months ago

Node.js v20 is now the latest LTS version of Node.js. Can this package support it please?

rvitaliy commented 7 months ago

according to packege.json configuration this vendor support "node": ">=14.0" see: https://github.com/twilio/twilio-node/blob/main/package.json#L76 but in the README say that it support only 14,16,18 https://github.com/twilio/twilio-node/blob/main/README.md?plain=1#L20 currently i use it on nodejs 20.9.0 without problem, but yes it's not the best solution since the tests runs only on 14,16,18 see: https://github.com/twilio/twilio-node/blob/main/.github/workflows/test-and-deploy.yml#L20C12-L20C12

please, can you start support nodejs v20 on your test suite too. 🙏

tiwarishubham635 commented 7 months ago

The support for node v20 has been temporarily removed due to an existing open issue with node v20. We are looking into it and will soon provide support for the LTS version of node.

jordan-bite commented 7 months ago

@tiwarishubham635 Can you provide link to where this is currently being tracked?

Joeao commented 5 months ago

I believe that this issue can be closed as of the release of 4.20.1

tiwarishubham635 commented 5 months ago

LTS Support is added in 4.20.1. Closing this issue.