twilio / twilio-node

Node.js helper library

MIT License

1.37k stars 495 forks source link

chore: removed unnecessary badge and added relevant badges #995

Closed tiwarishubham635 closed 5 months ago

tiwarishubham635 commented 5 months ago

Fixes

Removed nodeio.co, twilioquest badges and added relevant badges for download counts and npm version

Checklist

[x] I acknowledge that all my contributions will be made under the project's license
[x] I have made a material change to the repo (functionality, testing, spelling, grammar)
[x] I have read the Contribution Guidelines and my PR follows them
[x] I have titled the PR appropriately
[x] I have updated my branch with the main branch
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added the necessary documentation about the functionality in the appropriate .md file
[ ] I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

bnb commented 5 months ago

looks like the npm version bade is breaking:

tiwarishubham635 commented 5 months ago

Hey @bnb! The seems to be working when I am looking at it. Maybe try clearing cache or opening from incognito browser?

tiwarishubham635 commented 5 months ago

But yeah there is some issue with this badge, since I am also seeing a 500 instead of version v4.20.1

tiwarishubham635 commented 5 months ago

Okay so I investigated over this. The image being rendered is being fetched from some third party API like badgen for npm version. The delay in response from there might cause the image to not render properly. However, the test badge is being used by a Github API only, so that should not break. However, I did saw that breaking as well at times. What is your suggestion? Should we look for other API or remove these badges?

tiwarishubham635 commented 5 months ago

Okay so I have removed the alt text that appears when badge is broken. So if the badge is broken, it won't show at all!

sonarcloud[bot] commented 5 months ago

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

tiwarishubham635 commented 5 months ago

Hi @bnb! Please check the changes and if this looks good then we can proceed with this

bnb commented 5 months ago

Looks good to me.