feat: move to built-in URL class

[43081j]

We currently use url-parse to deal with URL construction. Given our node engine constraint of >=14, we know URL is available in all supported node versions (introduced in 10.x if i remember correctly).

So we should be able to drop this dependency and use the built-in parser instead.

Note that one test here changed hash because url-parse incorrectly did not encode the single quotes in the test URL. With the standard URL parsing, it is now encoded.

Let me know if there's anything you want me to change here. Also, if someone could confirm i updated the test hash correctly, that'd be very helpful.

Checklist

• [x] I acknowledge that all my contributions will be made under the project's license
• [x] I have made a material change to the repo (functionality, testing, spelling, grammar)
• [x] I have read the Contribution Guidelines and my PR follows them
• [x] I have titled the PR appropriately
• [x] I have updated my branch with the main branch
• [x] I have added tests that prove my fix is effective or that my feature works
• [ ] I have added the necessary documentation about the functionality in the appropriate .md file
• [ ] I have added inline documentation to the code I modified

[tiwarishubham635]

Hi @43081j! Can you try running make prettier in your local repository before pushing? That should fix the this error.

[tiwarishubham635]

I have added your changes in a new branch to monitor the development. Please check here. Thanks!

[43081j]

no worries, thanks for picking this up!

do you want to close this one? since your PR will land the changes anyway

[tiwarishubham635]

no worries, thanks for picking this up!

do you want to close this one? since your PR will land the changes anyway

Yeah, i think we can proceed from this PR now

[tiwarishubham635]

We can close this PR now, please take a look at #1017 and let us know if everything is good. Thanks!