twilio / twilio-php

A PHP library for communicating with the Twilio REST API and generating TwiML.
MIT License
1.57k stars 562 forks source link

Deprecated: Values on PHP 8.1 #709

Closed pkristian closed 2 years ago

pkristian commented 2 years ago

Issue Summary

Class Values producess deprecated erros under PHP 8.1

Exception/Log

PHP Deprecated: Return type of Twilio\Values::offsetExists($offset) should either be compatible with
ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] 
attribute should be used to temporarily suppress 
the notice in /var/www/html/vendor/twilio/sdk/src/Twilio/Values.php:49

PHP Deprecated: Return type of Twilio\Values::offsetGet($offset) should either be compatible with
ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] 
attribute should be used to temporarily suppress 
the notice in /var/www/html/vendor/twilio/sdk/src/Twilio/Values.php:62

PHP Deprecated: Return type of Twilio\Values::offsetSet($offset, $value) should either be compatible with
ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] 
attribute should be used to temporarily suppress 
the notice in /var/www/html/vendor/twilio/sdk/src/Twilio/Values.php:79

PHP Deprecated: Return type of Twilio\Values::offsetUnset($offset) should either be compatible with
ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] 
attribute should be used to temporarily suppress
the notice in /var/www/html/vendor/twilio/sdk/src/Twilio/Values.php:92

Technical details:

shwetha-manvinkurke commented 2 years ago

This issue has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog.

icheko commented 2 years ago

+1

Dizzzlectic commented 2 years ago

+1

bradkane commented 2 years ago

+100

adheeshfordev commented 2 years ago

+1

shwetha-manvinkurke commented 2 years ago

Fixed by https://github.com/twilio/twilio-php/pull/713