phpfui commented 2 years ago

Fixes

Adds #[\ReturnTypeWillChange] where needed (according to unit tests).
Fixes a null parameter warning passed to trim in Version.
Updates PHPUnit to V7, but housekeeping only, as composer does the right thing normally.

[x] I acknowledge that all my contributions will be made under the project's license
[x] I have made a material change to the repo (functionality, testing, spelling, grammar)
[x] I have read the Contribution Guidelines and my PR follows them
[x] I have titled the PR appropriately
[x] I have updated my branch with the main branch
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added the necessary documentation about the functionality in the appropriate .md file
[x] I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

petewalker commented 2 years ago

This resolves #709 and #712 - @JenniferMah / @shwetha-manvinkurke any chance this could be looked at?

petewalker commented 2 years ago

@shwetha-manvinkurke Thanks for running the CI! Could this be merged?

deluxetom commented 2 years ago

Would be great if it was merged, thank you @phpfui for the hard work!

phpfui commented 2 years ago

Happy to help!

shwetha-manvinkurke commented 2 years ago

@phpfui could you fix the conflicts?

phpfui commented 2 years ago

Will have till wait till Monday. Skiing!

phpfui commented 2 years ago

This should now be good to merge. All tests run my Windows machine. I fixed a merge mistake from my merge with the web interface.

deluxetom commented 2 years ago

thanks @phpfui! looking forward to the new tag release.

twilio / twilio-php