twilio / twilio-python

A Python module for communicating with the Twilio API and generating TwiML.
MIT License
1.83k stars 699 forks source link

chore: use new unittest.mock from standard library #782

Closed a-detiste closed 3 months ago

a-detiste commented 5 months ago

https://github.com/testing-cabal/mock

"mock is now part of the Python standard library, available as unittest.mock in Python 3.3 onwards."

Checklist

tiwarishubham635 commented 4 months ago

I see some error here, can you check this?

a-detiste commented 4 months ago

Please merge https://github.com/twilio/twilio-python/pull/783 first and I will rebase if this can't be done automagicaly with github

a-detiste commented 3 months ago

So finally no #783 , I will trim this down

tiwarishubham635 commented 3 months ago

So there will be some changes in this repo and some in generator repo. We can use #783 for this repo's changes.

tiwarishubham635 commented 3 months ago

@a-detiste do you want to continue working on it?

a-detiste commented 3 months ago

Yes I can

a-detiste commented 3 months ago

Well it's done for me... only merge needed

tiwarishubham635 commented 3 months ago

Please check the failing tests. if mock is part of python since 3.3 then it should work fine with 3.7 as well