Closed kloczek closed 3 months ago
Is this Python 3.7 has reached its EOL?
I think you should also remove testing against python 3.7 here
Do you still want to support 3.7 ?
Do you still want to support 3.7 ?
I mean we can remove it since its EOL, would need to remove it from test file as well
As this is an extension of #781, it states:
According to https://endoflife.date/python python 3.7 is EOSed since 27 Jun 2023. Filter all code over pyupgrade --py38.
However, since we want to maintain support for python>=3.8, shouldn't we use the flag --py38-plus
?
As this is an extension of #781, it states:
According to https://endoflife.date/python python 3.7 is EOSed since 27 Jun 2023. Filter all code over pyupgrade --py38.
However, since we want to maintain support for python>=3.8, shouldn't we use the flag
--py38-plus
?
It is an mistake in commit comment.
$ pyupgrade --help
usage: pyupgrade [-h] [--exit-zero-even-if-changed] [--keep-percent-format] [--keep-mock] [--keep-runtime-typing] [--py3-plus] [--py36-plus] [--py37-plus] [--py38-plus] [--py39-plus]
[--py310-plus] [--py311-plus] [--py312-plus]
[filenames ...]
positional arguments:
filenames
options:
-h, --help show this help message and exit
--exit-zero-even-if-changed
--keep-percent-format
--keep-mock
--keep-runtime-typing
--py3-plus, --py3-only
--py36-plus
--py37-plus
--py38-plus
--py39-plus
--py310-plus
--py311-plus
--py312-plus
However, since we want to maintain support for python>=3.8, shouldn't we use the flag
--py38-plus
?
That is exact option which I've used 😋
Cool. Please remove the python 3.7 from test file and then I can review.
done
Hey @kloczek! There are some files in rest folder that are auto generated. For those files to reflect this change, we need to make changes in our generator repo. I'll do the same and update it here. Thanks!
OK. No problem. I understand 😄 Just cancel this PR and do how it should be done 😋
I have created an internal ticket for this issue to be fixed. Thanks!
Closing this as not planned
Checklist