twilio / twilio-ruby

A Ruby gem for communicating with the Twilio API and generating TwiML
MIT License
1.35k stars 462 forks source link

fix: move require into TwilioWebhookAuthentication initialize (Fixes twilio/twilio-ruby#592) #597

Closed engshien closed 2 years ago

engshien commented 2 years ago

Fixes

Fixes #592

I have moved the require into the initialize so it is only executed if the user needs the functionality. This is an alternative fix to just requiring the rack gem in the gemspec.

I have run the existing tests and my own tests that were failing in 5.63.1 due to the issue.

Checklist

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

philnash commented 2 years ago

Thank you for your contribution! Since this middleware is only important when rack is part of the application we've changed this in #602 so that if Rack is not present, the middleware doesn't get loaded. Version 5.65.1 was just released with this update, so you can now install the latest version and it will work again.