twilio / twilio-ruby

A Ruby gem for communicating with the Twilio API and generating TwiML
MIT License
1.35k stars 462 forks source link

fix: don't load webhook authentication if Rack not present #602

Closed philnash closed 2 years ago

philnash commented 2 years ago

Fixes #592

Now that the webhook authentication requires part of Rack to run, loading the gem in a context that doesn't include Rack fails. For most people this won't happen as it will be used in the context of a web framework and most Ruby web frameworks rely on Rack. However, simple scripts that don't have Rack loaded will fail because the application can't load rack/media_type. In these cases, since Rack is not present, rack middleware won't be helpful either, so we only load the Rack middleware if Rack is present.

Fixes

A short description of what this PR does.

Checklist

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.