search

twilio / twilio-ruby

A Ruby gem for communicating with the Twilio API and generating TwiML
MIT License
1.35k stars 462 forks source link

chore: update the user agent string for twilio-ruby #604

Closed claudiachua closed 2 years ago

claudiachua commented 2 years ago

Jira Issue: https://issues.corp.twilio.com/browse/DI-2050

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

fschwahn commented 2 years ago

This shells out twice, which seems a bit wasteful. Also, this looks as if it could cause cross-platform issues (ie. is uname -m supported on Windows?)

claudiachua commented 2 years ago

Hi fschwahn, that's was my oversight and thanks for pointing that out, I've put in a PR to the fix: https://github.com/twilio/twilio-ruby/pull/607