TLDR; bundle install and bundle install --with development both install the same set. So perhaps one without flag is clearer to use?
The setup script and the ci workflow definition specify that bundler should use --with development option, which has been deprecated as of newer version of bundler. Mine is 2.4.3.
[DEPRECATED] The `--with` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set --local with 'development'`, and stop using this flag
While the intention is apparently to restrict installed gems to development group, it makes no difference to the resulting installation set.
Here I propose that we drop the irrelevant flag. The discussion above in turn shows that gem 'simplecov' does not need to reside in test group, as it's been, and will be, installed regardless of the presence of --with. Therefore it's got rid of as well.
Checklist
[x] I acknowledge that all my contributions will be made under the project's license
[ ] I have made a material change to the repo (functionality, testing, spelling, grammar)
Thanks for the PR! We've added the review to our backlog to be prioritised. Pull requests and +1s on the issue summary will help it move up the backlog.
TLDR;
bundle install
andbundle install --with development
both install the same set. So perhaps one without flag is clearer to use?The setup script and the ci workflow definition specify that bundler should use
--with development
option, which has been deprecated as of newer version of bundler. Mine is 2.4.3.While the intention is apparently to restrict installed gems to development group, it makes no difference to the resulting installation set.
This is because we cannot rely on
--with
to opt out from installing grouped gems. What we might want to use is either--without
option orgroup :test, optional: true
. A relevant reference is here: https://bundler.io/guides/groups.html#optional-groups-and-bundlewithHere I propose that we drop the irrelevant flag. The discussion above in turn shows that
gem 'simplecov'
does not need to reside in test group, as it's been, and will be, installed regardless of the presence of--with
. Therefore it's got rid of as well.Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.