search

twilio / twilio-ruby

A Ruby gem for communicating with the Twilio API and generating TwiML
MIT License
1.35k stars 462 forks source link

Local Jump Error Listing Recordings #663

Open JYorston opened 1 year ago

JYorston commented 1 year ago

Issue Summary

Upgrading from 5.56.0 to 6.1.0 has introduced a bug for us in the following code.

Downgrading back to 5.56.0 resolves the issue.

Steps to Reproduce

  1. Run the below code snippet on 6.1.0, local jump error exists.
  2. Rollback to 5.56.0, error does not occur.

Code Snippet

        client = Twilio::REST::Client.new(api_key_sid, api_key_secret, account_sid)
        recordings = client.video.v1.recordings.list(grouping_sid: ['SOME_ROOM_ID'],
                                                    limit: 20)

Exception/Log

LocalJumpError: no block given (yield)
from /Users/jamesyorston/.rbenv/versions/2.7.6/lib/ruby/gems/2.7.0/gems/twilio-ruby-6.0.1/lib/twilio-ruby/framework/serialize.rb:77:in `block in serialize_list'

Technical details:

JYorston commented 1 year ago

https://github.com/twilio/twilio-ruby/pull/665

A small change, it appears this block used to be passed in previous versions and was removed. I have added it back in.

This fixes the issue.

AsabuHere commented 1 year ago

Hi @JYorston, Our team has reviewed and merged this PR. Please note that these are auto-generated files via our internal oai-generator, which would need modifications to incorporate this change in next generations. Tracked via DII-1038.

To unblock you in development usage, these changes are approved for now. Please wait till the next release for the fix to be available in sdk.

JYorston commented 1 year ago

@AsabuHere Great, thanks for the quick turn around!