search

twilio / twilio-video-app-react

A collaboration application built with the twilio-video.js SDK and React.js
Apache License 2.0
1.81k stars 728 forks source link

Bump Node version in requirements #599

Closed alex-konoval closed 2 years ago

alex-konoval commented 3 years ago

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

Pull Request Details

Description

Since @twilio/video-processors is added to dependencies, it requires Node 14+: https://github.com/twilio/twilio-video-processors.js/blob/2f25da6cbbaed41c694a8e87a359cc0a96305e31/package.json#L25-L27

olipyskoty commented 2 years ago

Hey @alex-konoval thanks so much for the pull request!

This PR looks great, but unfortunately I can't merge it because our CircleCI tests aren't allowed to run on third-party pull requests due to security concerns. I created a new PR (#621) that contains your commit, so when I merge it you'll still be listed as a contributor.

I'll close this PR and merge #621 in instead.

Thanks again!