search

twilio / twilio-video-app-react

A collaboration application built with the twilio-video.js SDK and React.js
Apache License 2.0
1.81k stars 728 forks source link

Video Quality - poor contrast and bright video images from Branch videos #680

Closed Tennisbum1 closed 2 years ago

Tennisbum1 commented 2 years ago

Question When playing videos on OnlyM downloaded from jw.org the contrast is poor and video appears visibly brighter than the original video. Other videos from other sources also. I would like some ideas to try. Thanks

Additional context Add any other context or screenshots about the your question here. The more detail, the better.

timmydoza commented 2 years ago

Hi @Tennisbum1 - thanks for the question!

I'm wondering if you could provide some more detail about the problem that you see? How are you playing videos with the twilio-video-app-react code? Are you sharing your screen to other participants in the room, and playing these OnlyM videos through the screen share?

Some screenshots of the problem that you see could make it easier for us to help you. In the meantime, it may be possible to change the brightness or other qualities of the screen share track by changing this code here: https://github.com/twilio/twilio-video-app-react/blob/master/src/components/VideoProvider/useScreenShareToggle/useScreenShareToggle.tsx#L19-L23

In that object, you can specify other properties, like brightness or exposureCompenstation (support for these may be device-specific). To see all the properties that could be used, you can look at this documentation from the Mozilla Developer Network: https://developer.mozilla.org/en-US/docs/web/api/mediatrackconstraints#properties_of_image_tracks

timmydoza commented 2 years ago

Closing due to inactivity. I'm happy to reopen the issue if more information is provided!