twilio / twilio-video-app-react

A collaboration application built with the twilio-video.js SDK and React.js
Apache License 2.0
1.8k stars 725 forks source link

Update NPM scripts to allow usage in Windows #744

Closed timmydoza closed 2 years ago

timmydoza commented 2 years ago

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

Pull Request Details

JIRA link(s):

Description

This PR updates the NPM scripts to remove linux-only commands, which will allow npm start to be run on windows. This change updates the About modal to import the App's version number directly from package.json. I have verified that, after running npm run build that the version number is the only part of package.json that ends up in the final bundle. All other unused parts of package.json are not included.

Resolves: #743

Burndown

Before review

Before merge