twilio / twilio-video-app-react

A collaboration application built with the twilio-video.js SDK and React.js
Apache License 2.0
1.8k stars 725 forks source link

Store gcloud service account credentials in proper JSON format. #779

Closed manjeshbhargav closed 1 year ago

manjeshbhargav commented 1 year ago

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

Pull Request Details

Description

For some reason, when we download the service account credentials, it is stored in the following format:

{
  ...
}

some-hex-number

This results in the application server's JSON parser failing to parse the credentials. So, this PR fixes the problem by removing the hexadecimal number from the output.

Burndown

Before review

Before merge