Snk pr

[olipyskoty]

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

• [x] I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

• VIDEO-10586

Description

This PR updates the following dependencies to the versions listed below:

• react-scripts: 5.0.0
• @types-jest: 27.5.2
• ts-jest: 27.0.1

Note, the new version of react-scripts upgraded jest to v27 which included some breaking changes. This includes setting the testing environment to node by default (see here). Note that this change caused 25 test suites to fail, so I configured the testing environment to jsdom by default.

In addition, eslint-plugin-testing-library was also upgraded with breaking changes, so you'll notice some syntax updates to some of the test files that use RTL.

Burndown

Before review

• [ ] Updated CHANGELOG.md if necessary
• [] Added unit tests if necessary
• [ ] Updated affected documentation
• [x] Verified locally with npm test
• [x] Manually sanity tested running locally
• [ ] Included screenshot as PR comment (if needed)
• [x] Ready for review

Before merge

• [ ] Got one or more +1s
• [ ] Re-tested if necessary

[timmydoza]

Looks good! Just need some carats.

Also, one idea I had while we're here making a big mess of the package-lock file, is that another thing that we can do is update all the little transient dependencies in the package-lock file. We can do this by deleting node_modules and package-lock.json, then simply running npm install again. It'll install a fresh round of packages, which might keep some future snyk PRs away.

I found that this does update the typescript version, and that does cause one error, but it's an easy fix. What do you think?