search

twilio / twilio-video-ios

Programmable Video SDK by Twilio
http://twilio.com/video
Other
64 stars 22 forks source link

Contrast problem during screen sharing #146

Open verboomp opened 3 years ago

verboomp commented 3 years ago

Description

We are using iOS ReplayKit to screen share the content from our app to a users browser. We are basically following the code provided here: https://github.com/twilio/video-quickstart-ios/tree/master/ReplayKitExample to implement the iOS part. For streaming testing I am using the twilio video-quickstart-js application. Everything is working fine except for a weird contrast problem. In Safari (on Mac didn't try safari for windows) everything looks fine and it is exactly like on the iPad but on other browsers (Chrome, FireFox, Edge) we have a contrast problem. It is most noticeable when we use yellow text/icons on a white background ( I know not the best combination but can't change it). On safari the text is readable fine but on Chrome/FF/edge the yellow is less yellow and more "turning" to white so it becomes unreadable.
I have tried the different codecs VP8 / VP9 / H264 but the output on Chrome is still unusable. I have tried both P2P as small rooms but no improvement.

Did any of you have similar problems and have found a way around them?

Steps to Reproduce

  1. Start screen sharing with the code from https://github.com/twilio/video-quickstart-ios/tree/master/ReplayKitExample
  2. Stream to twilio video-quickstart-js application
  3. Stream a white page with yelow text in some smaller font type e.g. 10.

Code

// Code that helps reproduce the issue

Expected Behavior

The streamed screen should look the same on all the different mayor browsers.

Actual Behavior

Safari looks fine the other mayer browsers (FireFox, Chrome and Edge) it doesn't.

Reproduces How Often

100%

Logs

Debug level logs are helpful when investigating issues. To enable debug level logging, add the following code to your application:

TwilioVideoSDK.setLogLevel(.debug)
// Log output when the issue occurs

Versions

All relevant version information for the issue.

Video iOS SDK

3.7.2 Carthage version

Xcode

XCode 12.2

iOS Version

iOS 13.7 and iOS 14

iOS Device

iPad Pro 12.9 but also on different kind of iPads.

timrozum commented 3 years ago

Hi @verboomp,

I did some simple testing and I don't think I am able to reproduce the same problem. I did notice that yellow text on white background seems to degrade more than black text during network issues.

Could you provide the following so I can look into this further?

  1. A sample source image that I can drop in ReplayKitExample to cause the problem.
  2. Screenshots of the problem on Safari and Chrome.
  3. Are you using the screencast or broadcast feature in ReplayKitExample?

Thanks!

timrozum commented 3 years ago

@verboomp I am going to close this issue but feel free to respond here if you have more issues. Thanks!